[CI] Enable multibranch pipeline #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
Member
Author
|
If
|
v1v
commented
Dec 1, 2020
Comment on lines
+48
to
+49
| name 'RUBY_VERSION' | ||
| values 'ruby:2.7', 'ruby:2.6', 'ruby:2.5', 'ruby:2.4', 'ruby:2.3', 'jruby:9.2', 'jruby:9.1' |
Member
Author
There was a problem hiding this comment.
List of supported ruby versions to be tested:
- This is a subset of the existing ones in https://github.com/elastic/apm-agent-ruby/blob/master/.ci/.jenkins_ruby.yml
v1v
commented
Dec 1, 2020
.ci/Jenkinsfile
Outdated
Comment on lines
52
to
53
| name 'FRAMEWORK' | ||
| values 'rails-6.0', 'rails-5.2', 'rails-5.1', 'rails-4.2', 'sinatra-2.0', 'sinatra-1.4' |
Member
Author
There was a problem hiding this comment.
List of supported frameworks to be tested:
- This is a subset of the existing ones in https://github.com/elastic/apm-agent-ruby/blob/master/.ci/.jenkins_framework.yml
v1v
commented
Dec 1, 2020
| ENV PATH=/app/bin:$BUNDLE_BIN:$PATH | ||
|
|
||
| ENV FRAMEWORKS $FRAMEWORKS | ||
| ENV RUBY_IMAGE $RUBY_IMAGE |
Member
Author
There was a problem hiding this comment.
This will help to generate junit files with the ruby_image value in their names
v1v
commented
Dec 1, 2020
bin/dev
Outdated
| ' docker-compose run' \ | ||
| ' --rm' \ | ||
| " specs #{ARGV.join}" | ||
| exit $?.exitstatus unless $?.success? |
Member
Author
There was a problem hiding this comment.
If something goes wrong then this will help to report back the error
v1v
commented
Dec 1, 2020
| #!/bin/bash | ||
| set -x | ||
|
|
||
| runRspec(){ |
Member
Author
There was a problem hiding this comment.
Delegate the how to the function then junit reporting are generated with a different name
This reverts commit 0d34bb0.
… a docker container
v1v
commented
Dec 1, 2020
Comment on lines
+27
to
+29
| # Copy cached folder to speed up docker containers | ||
| COPY vendor /vendor | ||
| RUN chown -R $USER_ID_GROUP /vendor |
Member
Author
There was a problem hiding this comment.
This is required to use the cached artifacts if required, otherwise the docker build uses the VENDOR_PATH but the docker run overrides it, as a consequence it fails in the CI.
When building a docker image there is now way to mount volumes but using the COPY, this will help to reuse the existing local cache artifacts.
This reverts commit 56ec9f9.
kuisathaverat
approved these changes
Dec 1, 2020
cachedout
approved these changes
Dec 1, 2020
mikker
approved these changes
Dec 2, 2020
Contributor
mikker
left a comment
mikker
left a comment
There was a problem hiding this comment.
This is SO GOOD, Victor! Can we bring some of this back to the agent's setup? The split GH checks, the caching changes, whatever else you have in store 😊
Co-authored-by: Mikkel Malmberg <mikkel@brnbw.com>
Contributor
Member
Author
|
@mikker , see the comment -> #4 (comment) It contains all the digested details from the build, so it might be easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
apm-agent-rubywith theyarjufdependency.COPYdirective to enable the caching for the docker build, since docker run overrides the/vendorfolder.Why
Use CI Jenkins to run the builds/tests for this project
Questions